Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature#2715 #2848

Merged
merged 9 commits into from Aug 12, 2019
Merged

Feature#2715 #2848

merged 9 commits into from Aug 12, 2019

Conversation

sunbufu
Copy link
Contributor

@sunbufu sunbufu commented Aug 10, 2019

Fixes #2715.

Changes proposed in this pull request:

  1. add getQueryResultMetaData() method on QueryResult.
  2. add QueryResultMetaData on StreamQueryResult class.
  3. modify AggregationDistinctQueryResult constructor to use queryResultMetaData instead of columnLabelAndIndexMap.
  4. use HashMultimap instead of TreeMap on QueryResultMetaData.
  5. modify unit test class.
  6. add integrated test.

2. add QueryResultMetaData on StreamQueryResult class.
3. modify AggregationDistinctQueryResult constructor to use queryResultMetaData instead of columnLabelAndIndexMap.
4. use HashMultimap instead of TreeMap on QueryResultMetaData.
5. modify unit test class.
@coveralls
Copy link

coveralls commented Aug 10, 2019

Pull Request Test Coverage Report for Build 9124

  • 41 of 41 (100.0%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 64.902%

Files with Coverage Reduction New Missed Lines %
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java 3 76.0%
Totals Coverage Status
Change from base Build 231: 0.8%
Covered Lines: 9168
Relevant Lines: 14126

💛 - Coveralls

@tristaZero tristaZero merged commit 9d0af95 into apache:dev Aug 12, 2019
@terrymanu terrymanu added this to the 4.0.0-RC3 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization of DISTINCT SQL.
5 participants