Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SPI for Opentracing implements #2849

Closed
wants to merge 20 commits into from
Closed

add SPI for Opentracing implements #2849

wants to merge 20 commits into from

Conversation

betterjava
Copy link
Member

Fixes #2478.

Changes proposed in this pull request:

  • add SPI for Opentracing implements .
  • add opentracing SPI config for sharding-proxy.

@coveralls
Copy link

coveralls commented Aug 10, 2019

Pull Request Test Coverage Report for Build 9165

  • 11 of 21 (52.38%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 64.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-opentracing/src/main/java/org/apache/shardingsphere/opentracing/yaml/config/YamlOpenTracingConfiguration.java 0 2 0.0%
sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java 3 76.0%
Totals Coverage Status
Change from base Build 246: 0.005%
Covered Lines: 9101
Relevant Lines: 14075

💛 - Coveralls

@betterjava
Copy link
Member Author

Since I can not find a way to make shardingsphere support Skywalking,jaeger,zipkin by openstracing at the same time,So it make no sence for providing SPI for that. So I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SPI to handle initialization of different Opentracing implements
3 participants