Fix federated query LocalDateTime conversion #30935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Apr 17, 2024
| } | ||
| this.currentRow = 1 == metaData.getColumnCount() ? rowValues[0] : rowValues; | ||
| } | ||
|
|
||
| private Object getValue(final int index) throws SQLException { |
There was a problem hiding this comment.
Can you add e2e test for this convert logic?
There was a problem hiding this comment.
Hi mentor, there is no field related to datetime in the e2e standard table.
There was a problem hiding this comment.
Thank you for your feedback, we could consider add a e2e test table which contains all data type.
strongduanmu
approved these changes
Apr 17, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30764.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.