Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case to MaskMergedResult #30946

Merged
merged 4 commits into from Apr 20, 2024
Merged

Conversation

FrostyHec
Copy link
Contributor

@FrostyHec FrostyHec commented Apr 19, 2024

Fixes #30591

Changes proposed in this pull #request:

Add test case to MaskMergedResult

Additional: Sorry for bothering, this is my first time trying to participate in this project, so I may have some issues with the project's coding standards: In this test unit, using BeforeEach might improve code clarity and reduce code duplication, but this might require introducing the usage of "lenient", which some projects might not allow. May I ask if our project allows lenient? Thanks~


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@terrymanu terrymanu merged commit 6c172d5 into apache:master Apr 20, 2024
16 checks passed
@terrymanu terrymanu added this to the 5.5.1 milestone Apr 20, 2024
@FrostyHec FrostyHec deleted the issueNo30591 branch April 20, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more test cases on MaskMergedResult
2 participants