Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract DropResourceGroupStatement ... LoadIndexInfoStatement to reduce duplicate logic for MySQL and Doris #31763

Merged
merged 18 commits into from
Jun 19, 2024
Merged

Extract DropResourceGroupStatement ... LoadIndexInfoStatement to reduce duplicate logic for MySQL and Doris #31763

merged 18 commits into from
Jun 19, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Jun 19, 2024 •
edited
Loading

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Extract DropResourceGroupStatement ... LoadIndexInfoStatement to reduce duplicate logic for MySQL and Doris

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu
Extract AlterResourceGroupStatement to reduce duplicate logic for MyS…
7e97dd3 
…QL and doris
@strongduanmu
Extract BinlogStatement to reduce duplicate logic for MySQL and doris
9808fb2
@strongduanmu
Extract CacheIndexStatement to reduce duplicate logic for MySQL and d…
5695583 
…oris
@strongduanmu
Extract ChecksumTableStatement to reduce duplicate logic for MySQL an…
ca1efba 
…d doris
@strongduanmu
Extract CheckTableStatement to reduce duplicate logic for MySQL and d…
ea4db24 
…oris
@strongduanmu
Extract CloneActionSegment to reduce duplicate logic for MySQL and doris
5fa0312
@strongduanmu
Extract CreateLoadableFunctionStatement to reduce duplicate logic for…
fa5a919 
… MySQL and doris
@strongduanmu
Extract CreateResourceGroupStatement to reduce duplicate logic for My…
ceff4b1 
…SQL and doris
@strongduanmu
Extract DelimiterStatement to reduce duplicate logic for MySQL and doris
d769df4
@strongduanmu
Extract DropResourceGroupStatement to reduce duplicate logic for MySQ…
cf1ce15 
…L and doris
@strongduanmu
Extract HelpStatement to reduce duplicate logic for MySQL and doris
3b793a6
@strongduanmu
Extract InstallComponentStatement to reduce duplicate logic for MySQL…
f4d472f 
… and doris
@strongduanmu
Extract InstallPluginStatement to reduce duplicate logic for MySQL an…
646d594 
…d doris
@strongduanmu
Extract KillStatement to reduce duplicate logic for MySQL and doris
efa7b60
@strongduanmu
Extract LoadIndexInfoStatement to reduce duplicate logic for MySQL an…
197b3fb 
…d doris
@strongduanmu
Extract DropResourceGroupStatement to reduce duplicate logic for MySQ…
5b0cbd3 
…L and doris
@strongduanmu strongduanmu added this to the 5.5.1 milestone Jun 19, 2024
@strongduanmu strongduanmu changed the title Extract DropResourceGroupStatement ... to reduce duplicate logic for MySQL and Doris Extract DropResourceGroupStatement ... LoadIndexInfoStatement to reduce duplicate logic for MySQL and Doris Jun 19, 2024
@FlyingZC FlyingZC merged commit 9701c6f into apache:master Jun 19, 2024
141 checks passed
@strongduanmu strongduanmu deleted the dev-06193 branch June 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlyingZC FlyingZC FlyingZC approved these changes

Assignees
No one assigned
Labels
in: SQL parse type: refactor
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strongduanmu @FlyingZC