Extract remaining dal statement to reduce duplicate logic for MySQL and Doris #31770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaojinchao95
approved these changes
Jun 20, 2024
taojintianxia
pushed a commit
to taojintianxia/shardingsphere
that referenced
this pull request
Jun 21, 2024
…nd Doris (apache#31770) * Extract ShowDatabasesStatement to reduce duplicate logic for MySQL and doris * Remove useless DorisShowEnginesStatement and MySQLShowEnginesStatement * Extract ShowEngineStatement to reduce duplicate logic for MySQL and doris * Extract ShowErrorsStatement to reduce duplicate logic for MySQL and doris * Extract ShowEventsStatement to reduce duplicate logic for MySQL and doris * Extract ShowFunctionCodeStatement to reduce duplicate logic for MySQL and doris * Extract ShowFunctionStatusStatement to reduce duplicate logic for MySQL and doris * Extract ShowGrantsStatement to reduce duplicate logic for MySQL and doris * Extract ShowIndexStatement to reduce duplicate logic for MySQL and doris * Extract ShowMasterStatusStatement to reduce duplicate logic for MySQL and doris * Extract ShowOpenTablesStatement to reduce duplicate logic for MySQL and doris * Extract ShowOtherStatement to reduce duplicate logic for MySQL and doris * Extract ShowPluginsStatement to reduce duplicate logic for MySQL and doris * Extract ShowPrivilegesStatement to reduce duplicate logic for MySQL and doris * Extract ShowPrivilegesStatement to reduce duplicate logic for MySQL and doris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.