Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navicat connect Sharding-Proxy no primary key error. #3379

Merged
merged 8 commits into from
Oct 29, 2019
Merged

Fix Navicat connect Sharding-Proxy no primary key error. #3379

merged 8 commits into from
Oct 29, 2019

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Oct 26, 2019

Fixes #3005

Changes proposed in this pull request:

  • ColumnMetaData class add notNull & autoIncrement field, to return column detail flags.
  • QueryHeader class add signed, primaryKey, nullable, autoIncrement field.
  • add MySQLColumnFieldDetailFlag class, is a enum class for table column all flag type.

This PR only solve this problem in sharding scenario.
If no Sharding, only Master-Slave, this error will still occur, because Master-Slave scenario, the TableMeta will not be pre loaded.

@coveralls
Copy link

coveralls commented Oct 26, 2019

Pull Request Test Coverage Report for Build 760

  • 30 of 74 (40.54%) changed or added relevant lines in 14 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.0006%) to 68.423%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/column/EncryptColumnMetaData.java 0 1 0.0%
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/column/ShardingGeneratedKeyColumnMetaData.java 0 1 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandler.java 0 2 0.0%
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/metadata/TableMetaDataLoader.java 0 6 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java 12 18 66.67%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/text/query/MySQLComQueryPacketExecutor.java 0 11 0.0%
sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/MySQLColumnFieldDetailFlag.java 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/column/ShardingGeneratedKeyColumnMetaData.java 1 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandler.java 1 0.0%
sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java 3 93.02%
sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/boot/SpringBootConfiguration.java 4 85.71%
Totals Coverage Status
Change from base Build 510: -0.0006%
Covered Lines: 11467
Relevant Lines: 16759

💛 - Coveralls

Copy link
Member

@tuohai666 tuohai666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check why the Coverage decreased.

@dongzl
Copy link
Contributor Author

dongzl commented Oct 29, 2019

I have added test case about the modified class files. But Coverage still decreased.

The org.apache.shardingsphere.shardingjdbc.spring.boot.SpringBootConfiguration case this problem, but I don't modified this file.

and how to increase the coverage?

@tuohai666
Copy link
Member

I have added test case about the modified class files. But Coverage still decreased.

The org.apache.shardingsphere.shardingjdbc.spring.boot.SpringBootConfiguration case this problem, but I don't modified this file.

and how to increase the coverage?

I think we can ignore that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants