-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Navicat connect Sharding-Proxy no primary key error. #3379
Conversation
...ingsphere/shardingproxy/transport/mysql/packet/command/query/MySQLColumnFieldDetailFlag.java
Outdated
Show resolved
Hide resolved
...ingsphere/shardingproxy/transport/mysql/packet/command/query/MySQLColumnFieldDetailFlag.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/org/apache/shardingsphere/core/metadata/column/EncryptColumnMetaData.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/shardingsphere/core/metadata/column/ShardingGeneratedKeyColumnMetaData.java
Outdated
Show resolved
Hide resolved
...ecute/src/main/java/org/apache/shardingsphere/core/execute/metadata/TableMetaDataLoader.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/context/EncryptRuntimeContext.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/shardingsphere/shardingproxy/backend/response/query/QueryHeader.java
Show resolved
Hide resolved
...sphere/shardingproxy/transport/mysql/packet/command/query/MySQLColumnDefinition41Packet.java
Outdated
Show resolved
Hide resolved
...sphere/shardingproxy/transport/mysql/packet/command/query/MySQLColumnDefinition41Packet.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check why the Coverage decreased.
I have added test case about the modified class files. But Coverage still decreased. The and how to increase the coverage? |
...mmon/src/main/java/org/apache/shardingsphere/core/metadata/column/EncryptColumnMetaData.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/org/apache/shardingsphere/core/metadata/column/EncryptColumnMetaData.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/shardingsphere/core/metadata/column/ShardingGeneratedKeyColumnMetaData.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/shardingsphere/core/metadata/column/ShardingGeneratedKeyColumnMetaData.java
Outdated
Show resolved
Hide resolved
I think we can ignore that file. |
Fixes #3005
Changes proposed in this pull request:
ColumnMetaData
class addnotNull
&autoIncrement
field, to return column detail flags.QueryHeader
class addsigned
,primaryKey
,nullable
,autoIncrement
field.MySQLColumnFieldDetailFlag
class, is a enum class for table column all flag type.This PR only solve this problem in sharding scenario.
If no Sharding, only Master-Slave, this error will still occur, because Master-Slave scenario, the TableMeta will not be pre loaded.