modify sharding-jdbc-orchestration-spring-boot-starter for orchestration-5.x #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration-5.x. 2. modify ShardingOrchestrationFacade's StateService ConfigurationService to use orchestration name. 3. modify unit test classes.
wgy8283335
requested changes
Dec 8, 2019
...pring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Show resolved
Hide resolved
wgy8283335
approved these changes
Dec 8, 2019
dongzl
requested changes
Dec 8, 2019
.../apache/shardingsphere/orchestration/temp/internal/registry/ShardingOrchestrationFacade.java
Outdated
Show resolved
Hide resolved
.../apache/shardingsphere/orchestration/temp/internal/registry/ShardingOrchestrationFacade.java
Show resolved
Hide resolved
...rdingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java
Outdated
Show resolved
Hide resolved
...rdingjdbc/orchestration/spring/boot/type/OrchestrationSpringBootRegistryMasterSlaveTest.java
Outdated
Show resolved
Hide resolved
dongzl
approved these changes
Dec 13, 2019
wgy8283335
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3185.
Changes proposed in this pull request:
sharding-jdbc-orchestration-spring-boot-starterfor orchestration-5.x.