#3256 Provider Scaling out Interface-Add all apis #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
requested changes
Dec 9, 2019
| java ${JAVA_OPTS} -classpath ${CLASS_PATH} ${MAIN_CLASS} |
There was a problem hiding this comment.
Moving port to configFile maybe better. You can refer Bootstrap in sharding-proxy.
| @@ -49,72 +41,36 @@ | |||
| @Slf4j | |||
| public class Bootstrap { | |||
|
|
|||
| private static final int PORT = Integer.parseInt(System.getProperty("port", "8080")); | |||
|
|
|||
There was a problem hiding this comment.
Moving port to configFile maybe better. You can refer Bootstrap in sharding-proxy.
There was a problem hiding this comment.
I will submit a new issue for config related, so here will stay as it is?
| "pushTimeout": 1000, | ||
| "concurrency": 3 | ||
| } | ||
| } |
There was a problem hiding this comment.
Please end file with blank line.
| @Data | ||
| public class Job { | ||
| private int id; | ||
| } |
There was a problem hiding this comment.
Can you replace this class by ShardingScalingJob?
There was a problem hiding this comment.
Yes, it is a good idea.
|
|
||
| private final BlockingQueue<Record> queue = new ArrayBlockingQueue<>(ScalingContext.getInstance().getServerConfiguration().getBlockQueueSize()); | ||
| private final BlockingQueue<Record> queue = new ArrayBlockingQueue<>(10000); |
There was a problem hiding this comment.
Why do you use hardcode in there?
There was a problem hiding this comment.
I will submit a new issue for config related.
KomachiSion
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3256.
Changes proposed in this pull request: