Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mysql-client8 for sharding-proxy #5218

Merged
merged 6 commits into from
Apr 17, 2020

Conversation

cherrylzhao
Copy link
Member

implement AUTH_PLUGIN and AUTHENTICATION_METHOD_MISMATCH to support mysql8 in sharding-proxy according https://dev.mysql.com/doc/internals/en/connection-phase.html

@codecov-io
Copy link

Codecov Report

Merging #5218 into master will decrease coverage by 0.07%.
The diff coverage is 72.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5218      +/-   ##
============================================
- Coverage     54.07%   53.99%   -0.08%     
- Complexity      406      408       +2     
============================================
  Files          1159     1162       +3     
  Lines         20604    20636      +32     
  Branches       3712     3717       +5     
============================================
+ Hits          11141    11143       +2     
- Misses         8766     8793      +27     
- Partials        697      700       +3     
Impacted Files Coverage Δ Complexity Δ
.../protocol/mysql/constant/MySQLConnectionPhase.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...cket/handshake/MySQLHandshakeResponse41Packet.java 95.83% <0.00%> (-2.09%) 0.00 <0.00> (ø)
...ase/protocol/mysql/payload/MySQLPacketPayload.java 97.05% <0.00%> (-2.95%) 0.00 <0.00> (ø)
...l/mysql/packet/handshake/MySQLHandshakePacket.java 81.48% <25.00%> (-7.41%) 1.00 <0.00> (ø)
...packet/handshake/MySQLAuthSwitchRequestPacket.java 80.00% <80.00%> (ø) 0.00 <0.00> (?)
...frontend/mysql/auth/MySQLAuthenticationEngine.java 87.17% <85.71%> (+0.22%) 0.00 <0.00> (ø)
...rontend/mysql/auth/MySQLAuthenticationHandler.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...e/protocol/mysql/constant/MySQLCapabilityFlag.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...acket/handshake/MySQLAuthSwitchResponsePacket.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...gscaling/core/synctask/DefaultSyncTaskFactory.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f102fa5...0f70138. Read the comment docs.

@tuohai666 tuohai666 merged commit 2e96bfb into apache:master Apr 17, 2020
microtimber pushed a commit to microtimber/shardingsphere that referenced this pull request May 6, 2020
* calculate lower 2 bytes and upper 2 bytes according to mysql protocol

* support mysql8 for sharding-proxy

* fix unit test

* implement AUTHENTICATION_METHOD_MISMATCH of mysql for mysql

* fix bad db error.

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants