-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support mysql-client8 for sharding-proxy #5218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5218 +/- ##
============================================
- Coverage 54.07% 53.99% -0.08%
- Complexity 406 408 +2
============================================
Files 1159 1162 +3
Lines 20604 20636 +32
Branches 3712 3717 +5
============================================
+ Hits 11141 11143 +2
- Misses 8766 8793 +27
- Partials 697 700 +3
Continue to review full report at Codecov.
|
tuohai666
approved these changes
Apr 17, 2020
This was referenced Apr 20, 2020
Closed
Closed
microtimber
pushed a commit
to microtimber/shardingsphere
that referenced
this pull request
May 6, 2020
* calculate lower 2 bytes and upper 2 bytes according to mysql protocol * support mysql8 for sharding-proxy * fix unit test * implement AUTHENTICATION_METHOD_MISMATCH of mysql for mysql * fix bad db error. * add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement AUTH_PLUGIN and AUTHENTICATION_METHOD_MISMATCH to support mysql8 in sharding-proxy according https://dev.mysql.com/doc/internals/en/connection-phase.html