New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] fetch data at componentDidMount #344

Merged

dengliming merged 1 commit into apache:master from VampireAchao:apache-master-patch-1

Sep 23, 2023

Contributor

VampireAchao commented Sep 23, 2023

see: https://legacy.reactjs.org/blog/2018/03/27/update-on-async-rendering.html#fetching-external-data

The above code is problematic for both server rendering (where the external data won’t be used) and the upcoming async rendering mode (where the request might be initiated multiple times).

The recommended upgrade path for most use cases is to move data-fetching into componentDidMount


          [Improve] fetch data at componentDidMount

964f65e

VampireAchao mentioned this pull request

[Task] [Optimization] Optimizing Deprecated React Lifecycle #341

Closed

18 tasks

dengliming approved these changes

View reviewed changes

dengliming added the type: enhancement label

dengliming merged commit d680ea3 into apache:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment