Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etcd register center #1161

Merged
merged 2 commits into from Mar 9, 2021
Merged

Etcd register center #1161

merged 2 commits into from Mar 9, 2021

Conversation

freedom-xiao007
Copy link
Contributor

// Describe your PR here; eg. Fixes #1147

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

<dependency>
<groupId>org.dromara</groupId>
<artifactId>soul-register-client-api</artifactId>
<version>2.3.0-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ${project.version}

<dependency>
<groupId>org.dromara</groupId>
<artifactId>soul-common</artifactId>
<version>2.3.0-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ${project.version}

@codecov-io
Copy link

Codecov Report

Merging #1161 (e89696c) into master (cee1d70) will decrease coverage by 0.20%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1161      +/-   ##
============================================
- Coverage     73.39%   73.19%   -0.21%     
- Complexity     2116     2121       +5     
============================================
  Files           365      365              
  Lines          8040     8047       +7     
  Branches        875      876       +1     
============================================
- Hits           5901     5890      -11     
- Misses         1701     1721      +20     
+ Partials        438      436       -2     
Impacted Files Coverage Δ Complexity Δ
...g/dromara/soul/plugin/base/AbstractSoulPlugin.java 69.04% <0.00%> (ø) 16.00 <1.00> (ø)
...soul/client/tars/TarsServiceBeanPostProcessor.java 33.33% <37.50%> (-51.81%) 8.00 <0.00> (-6.00)
...java/org/dromara/soul/admin/entity/SelectorDO.java 94.44% <100.00%> (ø) 4.00 <0.00> (ø)
.../soul/plugin/httpclient/NettyHttpClientPlugin.java 57.14% <0.00%> (-2.05%) 10.00% <0.00%> (ø%)
...omara/soul/sync/data/http/HttpSyncDataService.java 72.54% <0.00%> (+3.92%) 12.00% <0.00%> (ø%)
.../soul/admin/service/impl/UpstreamCheckService.java 64.48% <0.00%> (+8.41%) 16.00% <0.00%> (+1.00%)
...iter/algorithm/ConcurrentRateLimiterAlgorithm.java 100.00% <0.00%> (+100.00%) 3.00% <0.00%> (+3.00%)
...ter/algorithm/LeakyBucketRateLimiterAlgorithm.java 100.00% <0.00%> (+100.00%) 3.00% <0.00%> (+3.00%)
...r/algorithm/SlidingWindowRateLimiterAlgorithm.java 100.00% <0.00%> (+100.00%) 4.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee1d70...e89696c. Read the comment docs.

freedom-xiao007 and others added 2 commits March 9, 2021 11:26
fix tars and grpc register

fix uri register

fix ci

Update application.yml

fix example desc

fix maven version
* fix typo

* fix typo
@yu199195 yu199195 added this to the 2.3.0 milestone Mar 9, 2021
@yu199195 yu199195 merged commit c58b12d into apache:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ETCD as soul-register-center
4 participants