Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all non-standard yaml file #1818

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Conversation

Switch-vov
Copy link
Contributor

Format all non-standard yaml file

shenyu-integrated-test-http:
container_name: shenyu-integrated-test-http
image: apache/shenyu-integrated-test-http:latest
# image: apache/shenyu-bootstrap:2.4.0-SNAPSHOT
#image: apache/shenyu-bootstrap:2.4.0-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found other # are in the beginning of the line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tydhot
Copy link
Member

tydhot commented Jul 28, 2021

Welcome

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #1818 (d0f3129) into master (a34f181) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1818      +/-   ##
============================================
- Coverage     62.75%   62.51%   -0.24%     
+ Complexity     2473     2470       -3     
============================================
  Files           488      488              
  Lines         10776    10776              
  Branches       1076     1076              
============================================
- Hits           6762     6737      -25     
- Misses         3491     3512      +21     
- Partials        523      527       +4     
Impacted Files Coverage Δ
...enyu/client/tars/TarsServiceBeanPostProcessor.java 58.10% <0.00%> (-32.44%) ⬇️
...t/zookeeper/ZookeeperClientRegisterRepository.java 70.90% <0.00%> (-1.82%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 71.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34f181...d0f3129. Read the comment docs.

@tydhot tydhot merged commit 06fb06c into apache:master Jul 28, 2021
@Switch-vov Switch-vov deleted the adjust_yaml_format branch July 28, 2021 11:05
renjugokulam pushed a commit to shivagowda/incubator-shenyu that referenced this pull request Aug 11, 2021
* Format all non-standard yaml file

* Update line comment to line first character
renjugokulam added a commit to shivagowda/incubator-shenyu that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants