Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:refactor] add an authentication on shenyu admin when register by http #2723

Merged
merged 17 commits into from
Jan 7, 2022
Merged

Conversation

SaberSola
Copy link
Contributor

@SaberSola SaberSola commented Jan 6, 2022

Fix #2724

The corresponding function in the org.apache.shenyu.admin.controller.ShenyuHttpRegistryController, can register a gateway with out authentication, this pr will fix it

@SaberSola SaberSola changed the title [type:refactor] Add an authentication on [type:refactor] add an authentication on shenyu admin when register by http Jan 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #2723 (b0b1321) into master (d95e8f8) will decrease coverage by 0.19%.
The diff coverage is 32.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2723      +/-   ##
============================================
- Coverage     60.37%   60.18%   -0.20%     
- Complexity     4394     4406      +12     
============================================
  Files           680      681       +1     
  Lines         19472    19574     +102     
  Branches       1727     1735       +8     
============================================
+ Hits          11757    11781      +24     
- Misses         6729     6799      +70     
- Partials        986      994       +8     
Impacted Files Coverage Δ
...e/shenyu/admin/shiro/bean/StatelessAuthFilter.java 54.54% <0.00%> (ø)
...a/org/apache/shenyu/common/constant/Constants.java 50.00% <ø> (ø)
...rg/apache/shenyu/common/utils/FreshBeanHolder.java 0.00% <0.00%> (ø)
...pache/shenyu/plugin/base/AbstractShenyuPlugin.java 68.29% <0.00%> (ø)
...ster/client/http/HttpClientRegisterRepository.java 0.00% <0.00%> (ø)
...shenyu/register/client/http/utils/OkHttpTools.java 55.17% <0.00%> (-44.83%) ⬇️
...enyu/register/client/http/utils/RegisterUtils.java 23.07% <0.00%> (-76.93%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 74.26% <79.48%> (-6.93%) ⬇️
...pache/shenyu/sync/data/http/config/HttpConfig.java 84.61% <100.00%> (+4.61%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95e8f8...b0b1321. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants