Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG #4080]fix bug When using post requests, you can add parameters after the ur… #4089

Merged
merged 19 commits into from
Oct 26, 2022

Conversation

ableYang123
Copy link
Contributor

[BUG] When using post requests, you can add parameters after the url to crack signature authentication #4080

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #4089 (09150fe) into master (28c5594) will decrease coverage by 0.11%.
The diff coverage is 81.48%.

@@             Coverage Diff              @@
##             master    #4089      +/-   ##
============================================
- Coverage     70.31%   70.20%   -0.12%     
+ Complexity     6941     6917      -24     
============================================
  Files           944      944              
  Lines         25961    25961              
  Branches       2337     2336       -1     
============================================
- Hits          18255    18225      -30     
- Misses         6289     6317      +28     
- Partials       1417     1419       +2     
Impacted Files Coverage Δ
...java/org/apache/shenyu/plugin/sign/SignPlugin.java 93.75% <66.66%> (ø)
...java/org/apache/shenyu/common/utils/SignUtils.java 84.21% <78.57%> (-6.70%) ⬇️
...shenyu/plugin/sign/service/DefaultSignService.java 88.88% <85.71%> (-3.57%) ⬇️
...he/shenyu/plugin/sign/api/DefaultSignProvider.java 100.00% <100.00%> (ø)
...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java 100.00% <100.00%> (ø)
...org/apache/shenyu/plugin/sign/api/SignService.java 100.00% <100.00%> (ø)
...controller/ShenyuClientHttpRegistryController.java 77.77% <0.00%> (-22.23%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 52.94% <0.00%> (-11.77%) ⬇️
.../apache/shenyu/admin/model/dto/BatchCommonDTO.java 50.00% <0.00%> (-7.15%) ⬇️
...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java 57.14% <0.00%> (-7.15%) ⬇️
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yunlongn
yunlongn previously approved these changes Oct 17, 2022
@yunlongn
Copy link
Member

thank your pr. you can update the documentation. https://shenyu.apache.org/zh/docs/plugin-center/security/sign-plugin

ableYang123 added a commit to ableYang123/shenyu-website that referenced this pull request Oct 17, 2022
adapt the sign plugin modify
apache/shenyu#4089  [BUG #4080]fix bug When using post requests, you can add parameters after the ur… #4089
ableYang123 added a commit to ableYang123/shenyu-website that referenced this pull request Oct 17, 2022
adapt the sign plugin modify
apache/shenyu#4089  [BUG #4080]fix bug When using post requests, you can add parameters after the ur… #4089
ableYang123 added a commit to ableYang123/shenyu-website that referenced this pull request Oct 17, 2022
apache/shenyu#4089  [BUG #4080]fix bug When using post requests, you can add parameters after the ur… #4089
ableYang123 pushed a commit to ableYang123/shenyu-website that referenced this pull request Oct 18, 2022
apache/shenyu#4089  [BUG #4080]fix bug When using post requests, you can add parameters after the ur… #4089
dengliming pushed a commit to apache/shenyu-website that referenced this pull request Oct 24, 2022
apache/shenyu#4089  [BUG #4080]fix bug When using post requests, you can add parameters after the ur… #4089

Co-authored-by: minzi.yang <minzi.yang@fulintechfin.com>
@moremind
Copy link
Member

pls resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants