Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3450] add brpc integrated test #4319

Merged
merged 33 commits into from
Feb 17, 2023

Conversation

loongs-zhang
Copy link
Member

@loongs-zhang loongs-zhang commented Jan 15, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #4319 (8ee80f4) into master (962277f) will decrease coverage by 0.11%.
The diff coverage is 17.24%.

@@             Coverage Diff              @@
##             master    #4319      +/-   ##
============================================
- Coverage     68.36%   68.25%   -0.11%     
+ Complexity     7514     7511       -3     
============================================
  Files          1020     1020              
  Lines         28813    28871      +58     
  Branches       2568     2579      +11     
============================================
+ Hits          19699    19707       +8     
- Misses         7579     7623      +44     
- Partials       1535     1541       +6     
Impacted Files Coverage Δ
.../common/dto/convert/plugin/BrpcRegisterConfig.java 0.00% <0.00%> (ø)
...henyu/plugin/brpc/handler/BrpcMetaDataHandler.java 0.00% <0.00%> (ø)
...che/shenyu/plugin/brpc/proxy/BrpcProxyService.java 2.08% <0.00%> (+0.04%) ⬆️
...enyu/plugin/brpc/cache/ApplicationConfigCache.java 34.34% <13.15%> (-15.01%) ⬇️
...ache/shenyu/client/brpc/common/dto/BrpcRpcExt.java 30.00% <33.33%> (-1.82%) ⬇️
...client/brpc/BrpcContextRefreshedEventListener.java 70.00% <100.00%> (ø)
...in/java/org/apache/shenyu/common/dto/RuleData.java 74.44% <0.00%> (-11.27%) ⬇️
...enyu/admin/service/publish/RuleEventPublisher.java 10.20% <0.00%> (-2.00%) ⬇️
.../plugin/base/cache/CommonPluginDataSubscriber.java 72.64% <0.00%> (-1.40%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@JooKS-me JooKS-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add brpc-it to here,

- shenyu-integrated-test-grpc

@loongs-zhang
Copy link
Member Author

sure, copy that.

@loongs-zhang
Copy link
Member Author

There is a problem with the implementation of the brpc plugin. The brpc integration test will be supported in the next version.

Copy link
Member

@JooKS-me JooKS-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JooKS-me JooKS-me merged commit 175459c into apache:master Feb 17, 2023
@JooKS-me JooKS-me added this to the 2.6.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants