-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3450] add brpc integrated test #4319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4319 +/- ##
============================================
- Coverage 68.36% 68.25% -0.11%
+ Complexity 7514 7511 -3
============================================
Files 1020 1020
Lines 28813 28871 +58
Branches 2568 2579 +11
============================================
+ Hits 19699 19707 +8
- Misses 7579 7623 +44
- Partials 1535 1541 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add brpc-it to here,
- shenyu-integrated-test-grpc |
sure, copy that. |
There is a problem with the implementation of the brpc plugin. The brpc integration test will be supported in the next version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true
.