Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:optimize] optimized version-one sign-plugin test, update shenyu-version #4332

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

tian-pengfei
Copy link
Contributor

@tian-pengfei tian-pengfei commented Jan 23, 2023

1.optimized version-one sign-plugin test
2. add more error message
3. update shenyu-version

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@tian-pengfei tian-pengfei changed the title Optimized [type:optimize] optimized version-one sign-plugin test Jan 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #4332 (c987c0b) into master (0a136fa) will decrease coverage by 0.04%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##             master    #4332      +/-   ##
============================================
- Coverage     68.35%   68.31%   -0.04%     
+ Complexity     7512     7508       -4     
============================================
  Files          1020     1020              
  Lines         28797    28800       +3     
  Branches       2567     2568       +1     
============================================
- Hits          19684    19675       -9     
- Misses         7577     7589      +12     
  Partials       1536     1536              
Impacted Files Coverage Δ
...a/org/apache/shenyu/common/constant/Constants.java 66.66% <ø> (ø)
...shenyu/plugin/sign/extractor/DefaultExtractor.java 60.00% <0.00%> (ø)
...nyu/plugin/sign/service/ComposableSignService.java 88.73% <0.00%> (-3.92%) ⬇️
.../apache/shenyu/plugin/sign/api/SignParameters.java 100.00% <100.00%> (ø)
.../client/server/consul/ShenyuConsulConfigWatch.java 60.41% <0.00%> (-22.92%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 62.41% <0.00%> (-1.35%) ⬇️
...henyu/common/cache/MemorySafeWindowTinyLFUMap.java 73.33% <0.00%> (ø)
...ruptor/RegisterClientServerDisruptorPublisher.java 66.66% <0.00%> (+11.11%) ⬆️
...controller/ShenyuClientHttpRegistryController.java 81.81% <0.00%> (+18.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

li-keguo
li-keguo previously approved these changes Jan 28, 2023
@tian-pengfei tian-pengfei changed the title [type:optimize] optimized version-one sign-plugin test [type:optimize] optimized version-one sign-plugin test,update shenyu-version Feb 9, 2023
@tian-pengfei tian-pengfei changed the title [type:optimize] optimized version-one sign-plugin test,update shenyu-version [type:optimize] optimized version-one sign-plugin test, update shenyu-version Feb 9, 2023
@yu199195 yu199195 merged commit fbec46c into apache:master Feb 9, 2023
@tian-pengfei tian-pengfei deleted the optimized branch February 13, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants