Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4334] optimize shenyu-admin (#4334) #4340

Merged
merged 5 commits into from Feb 7, 2023
Merged

[ISSUE #4334] optimize shenyu-admin (#4334) #4340

merged 5 commits into from Feb 7, 2023

Conversation

koonchen
Copy link
Contributor

#4334

i change some codes according to the grammar of java8, pls help to review

@koonchen koonchen changed the title Fix 4334 [ISSUE #4334] optimize shenyu-admin (#4334) Jan 31, 2023
@koonchen
Copy link
Contributor Author

@KevinClair Hi can you help me to run the test again?

@KevinClair
Copy link
Member

No need to create new pull request.Push to the origin branch if you have any changes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023 •
edited

Codecov Report

Merging #4340 (45be642) into master (45be642) will not change coverage.
The diff coverage is n/a.

❗ Current head 45be642 differs from pull request most recent head efc72e9. Consider uploading reports for the commit efc72e9 to get more accurate results

@@            Coverage Diff            @@
##             master    #4340   +/-   ##
=========================================
  Coverage     68.29%   68.29%           
  Complexity     7518     7518           
=========================================
  Files          1020     1020           
  Lines         28831    28831           
  Branches       2585     2585           
=========================================
  Hits          19690    19690           
  Misses         7605     7605           
  Partials       1536     1536

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@koonchen
Copy link
Contributor Author

koonchen commented Feb 1, 2023

No need to create new pull request.Push to the origin branch if you have any changes.

I get it, you are right. Can you help me review the code ?

@koonchen
Copy link
Contributor Author

koonchen commented Feb 1, 2023

@KevinClair I have fixed the above problem, pls help to review again, thx :)

@KevinClair KevinClair linked an issue Feb 2, 2023 that may be closed by this pull request
[Task] optimize shenyu-admin #4334
Closed
KevinClair
KevinClair previously approved these changes Feb 2, 2023
View reviewed changes
@koonchen
Copy link
Contributor Author

koonchen commented Feb 2, 2023

@KevinClair Can you help me merge to master? thx 🌹

@KevinClair
Copy link
Member

@KevinClair Can you help me merge to master? thx 🌹
Wait for the release to complete.

@koonchen
Copy link
Contributor Author

koonchen commented Feb 4, 2023

@KevinClair Sorry, I use rebase to upgrade the code, the previous code review is lost, PTAL~

@iwangjie iwangjie mentioned this pull request Feb 4, 2023
Closed
@koonchen
Copy link
Contributor Author

koonchen commented Feb 7, 2023

PTAL~

@KevinClair KevinClair added this to the 2.6.0 milestone Feb 7, 2023
@KevinClair KevinClair merged commit 20eebb7 into apache:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinClair KevinClair KevinClair approved these changes

Assignees
No one assigned
Labels
admin code: clean
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

[Task] optimize shenyu-admin
3 participants
@koonchen @KevinClair @codecov-commenter