Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zombieRemovalTimes lost #4368

Merged
merged 3 commits into from
Feb 10, 2023
Merged

fix zombieRemovalTimes lost #4368

merged 3 commits into from
Feb 10, 2023

Conversation

iwangjie
Copy link
Contributor

@iwangjie iwangjie commented Feb 9, 2023

fix zombieRemovalTimes assignment operation lost.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #4368 (6687b57) into master (0a136fa) will decrease coverage by 0.04%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##             master    #4368      +/-   ##
============================================
- Coverage     68.35%   68.31%   -0.04%     
+ Complexity     7512     7507       -5     
============================================
  Files          1020     1020              
  Lines         28797    28801       +4     
  Branches       2567     2568       +1     
============================================
- Hits          19684    19676       -8     
- Misses         7577     7590      +13     
+ Partials       1536     1535       -1     
Impacted Files Coverage Δ
...a/org/apache/shenyu/common/constant/Constants.java 66.66% <ø> (ø)
...shenyu/plugin/sign/extractor/DefaultExtractor.java 60.00% <0.00%> (ø)
...nyu/plugin/sign/service/ComposableSignService.java 88.73% <0.00%> (-3.92%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 62.66% <100.00%> (-1.10%) ⬇️
.../apache/shenyu/plugin/sign/api/SignParameters.java 100.00% <100.00%> (ø)
.../client/server/consul/ShenyuConsulConfigWatch.java 60.41% <0.00%> (-22.92%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 66.66% <0.00%> (+11.11%) ⬆️
...controller/ShenyuClientHttpRegistryController.java 81.81% <0.00%> (+18.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit ce1e586 into apache:master Feb 10, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants