Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task[#4379] Plugin upload hot load into Shenyu #4392

Merged
merged 35 commits into from
Mar 20, 2023

Conversation

ywj1352
Copy link
Contributor

@ywj1352 ywj1352 commented Feb 16, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@ywj1352 ywj1352 closed this Feb 16, 2023
@ywj1352 ywj1352 reopened this Feb 16, 2023
@ywj1352 ywj1352 closed this Feb 16, 2023
@ywj1352 ywj1352 reopened this Feb 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #4392 (077d234) into master (74c5022) will decrease coverage by 0.09%.
The diff coverage is 24.65%.

@@             Coverage Diff              @@
##             master    #4392      +/-   ##
============================================
- Coverage     68.11%   68.02%   -0.09%     
- Complexity     7549     7552       +3     
============================================
  Files          1027     1027              
  Lines         29266    29316      +50     
  Branches       2635     2641       +6     
============================================
+ Hits          19934    19943       +9     
- Misses         7755     7795      +40     
- Partials       1577     1578       +1     
Impacted Files Coverage Δ
...g/apache/shenyu/web/loader/ShenyuPluginLoader.java 59.66% <7.69%> (-15.16%) ⬇️
...rg/apache/shenyu/web/handler/ShenyuWebHandler.java 91.30% <40.00%> (-4.09%) ⬇️
.../apache/shenyu/web/loader/ShenyuLoaderService.java 72.41% <73.33%> (-18.07%) ⬇️
...pringboot/starter/gateway/ShenyuConfiguration.java 91.30% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ywj1352
Copy link
Contributor Author

ywj1352 commented Mar 17, 2023

image
it works in local

@mahaitao617 mahaitao617 merged commit 12a2c19 into apache:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants