Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Resolve shenyu project global version." #4394

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Revert "Resolve shenyu project global version." #4394

merged 4 commits into from
Feb 20, 2023

Conversation

damonxue
Copy link
Contributor

@yu199195 @li-keguo
(release-maven-plugin referred to as RMP)

I am very sorry to explain here, and request to restore the previous merger.

Here are the Reasons:

Ignorance of the RMP, I have just seen the pr #4350's files changed, Especially ignored the commit messages. I feel that changing the version impacts a number of too many files, based on experience, I mentioned the previous pr.

After an in-depth understanding of the RMP, there is no compromise solution, unless the extension RMP increases the extension implementation of the global version variable, but there is no need to go the other way.

Pls, revert the wrong pr, I will raise more issues to discuss in the future to improve the quality of pr.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #4394 (c9dc887) into master (85c0fb0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4394      +/-   ##
============================================
+ Coverage     68.21%   68.22%   +0.01%     
- Complexity     7491     7492       +1     
============================================
  Files          1020     1020              
  Lines         28871    28871              
  Branches       2579     2579              
============================================
+ Hits          19694    19697       +3     
+ Misses         7634     7631       -3     
  Partials       1543     1543              
Impacted Files Coverage Δ
...henyu/admin/service/impl/UpstreamCheckService.java 66.66% <0.00%> (-1.15%) ⬇️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 61.70% <0.00%> (+5.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-keguo li-keguo merged commit c0325c0 into apache:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants