Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:refactor] refactor code #4400

Merged
merged 6 commits into from
Feb 21, 2023
Merged

Conversation

mahaitao617
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #4400 (9ad6ae9) into master (c0325c0) will decrease coverage by 0.02%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##             master    #4400      +/-   ##
============================================
- Coverage     68.23%   68.21%   -0.02%     
+ Complexity     7493     7488       -5     
============================================
  Files          1020     1020              
  Lines         28871    28870       -1     
  Branches       2579     2577       -2     
============================================
- Hits          19699    19693       -6     
- Misses         7630     7635       +5     
  Partials       1542     1542              
Impacted Files Coverage Δ
.../client/server/consul/ShenyuConsulConfigWatch.java 87.23% <80.95%> (+1.81%) ⬆️
...controller/ShenyuClientHttpRegistryController.java 63.63% <0.00%> (-18.19%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 55.55% <0.00%> (-11.12%) ⬇️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 56.38% <0.00%> (-4.26%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 66.66% <0.00%> (-1.15%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 89.79% <0.00%> (+4.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mahaitao617 mahaitao617 changed the title feat:refine code refactor code Feb 20, 2023
moremind
moremind previously approved these changes Feb 21, 2023
@moremind moremind changed the title refactor code [type:refactor] refactor code Feb 21, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Feb 21, 2023
@yu199195 yu199195 merged commit 11d542b into apache:master Feb 21, 2023
@mahaitao617 mahaitao617 deleted the mht_refactor_220 branch February 21, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants