Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4399] check rule uri condition on save. #4403

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

iwangjie
Copy link
Contributor

fix #4399

image

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@iwangjie iwangjie changed the title check rule uri condition on save. [ISSUE #4399] check rule uri condition on save. Feb 22, 2023
@damonxue
Copy link
Contributor

It's not a review, just suggest. @iwangjie ( ﹁ ﹁ ) ~→

@iwangjie
Copy link
Contributor Author

iwangjie commented Feb 23, 2023

It's not a review, just suggest. @iwangjie ( ﹁ ﹁ ) ~→

😉Thank you for your patience. @damonxue

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #4403 (83625e0) into master (f88127f) will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #4403      +/-   ##
============================================
+ Coverage     68.04%   68.07%   +0.03%     
+ Complexity     7500     7499       -1     
============================================
  Files          1023     1023              
  Lines         29005    29013       +8     
  Branches       2592     2593       +1     
============================================
+ Hits          19736    19751      +15     
+ Misses         7720     7714       -6     
+ Partials       1549     1548       -1     
Impacted Files Coverage Δ
...a/org/apache/shenyu/admin/service/RuleService.java 77.77% <75.00%> (-22.23%) ⬇️
...shenyu/sync/data/consul/ConsulSyncDataService.java 80.00% <0.00%> (+1.66%) ⬆️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 60.63% <0.00%> (+4.25%) ⬆️
...ruptor/RegisterClientServerDisruptorPublisher.java 66.66% <0.00%> (+11.11%) ⬆️
...controller/ShenyuClientHttpRegistryController.java 81.81% <0.00%> (+18.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-keguo li-keguo merged commit 19c0fb2 into apache:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] verification of rule correctness.
5 participants