Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fix] fix loadbalance spi resources #4411

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

mahaitao617
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #4411 (8b89b07) into master (73287ec) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4411      +/-   ##
============================================
- Coverage     68.11%   68.09%   -0.02%     
+ Complexity     7485     7483       -2     
============================================
  Files          1021     1021              
  Lines         28913    28913              
  Branches       2584     2584              
============================================
- Hits          19693    19689       -4     
- Misses         7677     7681       +4     
  Partials       1543     1543              
Impacted Files Coverage Δ
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 56.38% <0.00%> (-5.32%) ⬇️
...shenyu/sync/data/consul/ConsulSyncDataService.java 80.00% <0.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moremind
Copy link
Member

SQL file had this configuration?

Copy link
Member

@moremind moremind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this to mysql/postgresql/oracle

Copy link
Member

@moremind moremind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not only spi file

@moremind moremind changed the title feat:fix spi resources [type:fix] fix loadbalance spi resources Feb 27, 2023
@moremind moremind merged commit a842a3b into apache:master Feb 27, 2023
@mahaitao617 mahaitao617 deleted the mht_spi_226 branch April 25, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants