Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4395] Add mapType to cryptor request and response plugin #4418

Merged
merged 12 commits into from
Mar 2, 2023
Merged

[ISSUE #4395] Add mapType to cryptor request and response plugin #4418

merged 12 commits into from
Mar 2, 2023

Conversation

damonxue
Copy link
Contributor

@damonxue damonxue commented Mar 1, 2023

#4395

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #4418 (531b647) into master (3a505a5) will decrease coverage by 0.02%.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##             master    #4418      +/-   ##
============================================
- Coverage     68.03%   68.01%   -0.02%     
  Complexity     7496     7496              
============================================
  Files          1022     1023       +1     
  Lines         28992    29005      +13     
  Branches       2592     2592              
============================================
+ Hits          19725    19729       +4     
- Misses         7718     7726       +8     
- Partials       1549     1550       +1     
Impacted Files Coverage Δ
...nyu/plugin/cryptor/handler/CryptorRuleHandler.java 35.00% <33.33%> (-0.30%) ⬇️
...he/shenyu/plugin/cryptor/strategy/MapTypeEnum.java 100.00% <100.00%> (ø)
...pache/shenyu/plugin/cryptor/utils/CryptorUtil.java 13.04% <100.00%> (-22.45%) ⬇️
...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java 68.75% <0.00%> (-31.25%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 85.71% <0.00%> (-4.09%) ⬇️
...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java 8.00% <0.00%> (-4.00%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 66.66% <0.00%> (+11.11%) ⬆️
...controller/ShenyuClientHttpRegistryController.java 81.81% <0.00%> (+18.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damonxue
Copy link
Contributor Author

damonxue commented Mar 1, 2023

@dragon-zhang
Pls help and review.

@damonxue
Copy link
Contributor Author

damonxue commented Mar 2, 2023

I will submit another pr later to increase the feature that fieldNames supports multiple fields. So there is a need to determine whether mapType should add the 'fields' option;

  • field map to value of a single field (Compatible with older versions)
  • all map to another JSON with whole fields;
  • field map to another JSON with the specified fields;

@yu199195 yu199195 merged commit f88127f into apache:master Mar 2, 2023
@damonxue damonxue deleted the issue_4395_cryptorReplaceType branch March 2, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants