Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4432] fix dubbo invoker cache bugs. #4433

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

iwangjie
Copy link
Contributor

@iwangjie iwangjie commented Mar 4, 2023

fix #4432

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #4433 (c94749e) into master (19c0fb2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4433      +/-   ##
============================================
- Coverage     68.02%   68.02%   -0.01%     
+ Complexity     7494     7493       -1     
============================================
  Files          1023     1023              
  Lines         29013    29013              
  Branches       2593     2594       +1     
============================================
- Hits          19736    19735       -1     
- Misses         7728     7729       +1     
  Partials       1549     1549              
Impacted Files Coverage Δ
...gin/apache/dubbo/cache/ApacheDubboConfigCache.java 64.76% <0.00%> (ø)
...henyu/admin/service/impl/UpstreamCheckService.java 66.09% <0.00%> (-1.15%) ⬇️
...shenyu/sync/data/consul/ConsulSyncDataService.java 80.00% <0.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iwangjie
Copy link
Contributor Author

iwangjie commented Mar 4, 2023

@mahaitao617 Hi. I have tested that it works in multiple namespaces, please review.

@mahaitao617 mahaitao617 merged commit f6d42e8 into apache:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dubbo gateway not correct used cache causes slow performance.
3 participants