[ISSUE #4469]add shortestResponseLoadBalancer #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4488 +/- ##
============================================
- Coverage 68.11% 68.03% -0.08%
- Complexity 7549 7561 +12
============================================
Files 1027 1028 +1
Lines 29266 29370 +104
Branches 2635 2652 +17
============================================
+ Hits 19934 19982 +48
- Misses 7755 7804 +49
- Partials 1577 1584 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
reviewed
Mar 19, 2023
| @@ -110,8 +114,15 @@ protected Mono<Void> doExecute(final ServerWebExchange exchange, final ShenyuPlu | |||
| exchange.getAttributes().put(Constants.RETRY_STRATEGY, StringUtils.defaultString(ruleHandle.getRetryStrategy(), RetryEnum.CURRENT.getName())); | |||
| exchange.getAttributes().put(Constants.LOAD_BALANCE, StringUtils.defaultString(ruleHandle.getLoadBalance(), LoadBalanceEnum.RANDOM.getName())); | |||
| exchange.getAttributes().put(Constants.DIVIDE_SELECTOR_ID, selector.getId()); | |||
| return ruleHandle.getLoadBalance().equals(P2C) ? chain.execute(exchange).doOnSuccess(e -> responseTrigger(upstream | |||
| )).doOnError(throwable -> responseTrigger(upstream)) : chain.execute(exchange); | |||
| if (ruleHandle.getLoadBalance().equals(P2C)) { | |||
There was a problem hiding this comment.
Different strategies require different methods to be implemented.Does it need improvement？
yu199195
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4469
add shortestResponseLoadBalancer