[FIX#4505] FileSizeFilter make memory leak #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
847850277
changed the title
yu199195
reviewed
Mar 28, 2023
| @@ -56,7 +57,7 @@ public class FileSizeFilter implements WebFilter { | |||
| private final List<HttpMessageReader<?>> messageReaders; | |||
|
|
|||
| public FileSizeFilter(final int fileMaxSize) { | |||
| HandlerStrategies handlerStrategies = HandlerStrategies.builder().codecs(configurer -> configurer.defaultCodecs().maxInMemorySize(fileMaxSize * BYTES_PER_MB)).build(); | |||
| HandlerStrategies handlerStrategies = HandlerStrategies.builder().codecs(configurer -> configurer.defaultCodecs().maxInMemorySize(-1)).build(); | |||
yu199195
reviewed
Mar 28, 2023
| })); | ||
| }); | ||
| }).doOnDiscard(DataBuffer.class, DataBufferUtils::release); |
Codecov Report
@@ Coverage Diff @@
## master #4507 +/- ##
============================================
+ Coverage 68.33% 68.42% +0.09%
- Complexity 7610 7614 +4
============================================
Files 1029 1029
Lines 29401 29403 +2
Branches 2659 2659
============================================
+ Hits 20090 20118 +28
+ Misses 7719 7694 -25
+ Partials 1592 1591 -1
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear community
1、Corrected
maxInMemorySizeto- 1to resolve theorg.springframework.core.io.buffer.DataBufferLimitException: Exceeded limit on max bytes to buffererror.2、Finally, the DataBuffer object was released.
please review code.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.