Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:bug] fix bug issue #4487. #4509

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

yunlongn
Copy link
Member

Fixes #4487

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #4509 (b54ac05) into master (a235b46) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4509      +/-   ##
============================================
+ Coverage     67.98%   68.06%   +0.08%     
- Complexity     7574     7577       +3     
============================================
  Files          1029     1029              
  Lines         29390    29401      +11     
  Branches       2655     2659       +4     
============================================
+ Hits          19981    20013      +32     
+ Misses         7821     7801      -20     
+ Partials       1588     1587       -1     
Impacted Files Coverage Δ
...apache/shenyu/common/utils/UpstreamCheckUtils.java 15.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@loongs-zhang loongs-zhang added the type: bug Something isn't working label Mar 29, 2023
@loongs-zhang loongs-zhang added this to the 2.6.0 milestone Mar 29, 2023
@loongs-zhang loongs-zhang merged commit 400fbe1 into apache:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <UpstreamCheckUtils#checkUrl>
3 participants