New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4508]Tolerant Path Slash. fix #4508 #4522
Conversation
@Configuration | ||
public class CollapseSlashesConfiguration { | ||
|
||
@Bean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a switch needs to be added here, otherwise all requests will go through this webfilter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a switch needs to be added here, otherwise all requests will go through this webfilter
Hi. do you mean a rule-level switch or a gateway-level switch? or plugin-level ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gateway-level , in application.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gateway-level , in application.yaml
OK, see what you mean. I'll fix it.
...bootstrap/src/main/java/org/apache/shenyu/bootstrap/config/CollapseSlashesConfiguration.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4522 +/- ##
============================================
- Coverage 68.55% 68.54% -0.02%
- Complexity 7636 7638 +2
============================================
Files 1028 1028
Lines 29443 29447 +4
Branches 2667 2667
============================================
- Hits 20185 20183 -2
- Misses 7661 7668 +7
+ Partials 1597 1596 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
before
after
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true
.