Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4508]Tolerant Path Slash. fix #4508 #4522

Merged
merged 5 commits into from Apr 6, 2023

Conversation

iwangjie
Copy link
Contributor

@iwangjie iwangjie commented Mar 31, 2023

before

image

after

image

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@iwangjie iwangjie changed the title Tolerant Path Slash. fix #4508 [ISSUE #4508]Tolerant Path Slash. fix #4508 Mar 31, 2023
@Configuration
public class CollapseSlashesConfiguration {

@Bean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a switch needs to be added here, otherwise all requests will go through this webfilter

Copy link
Contributor Author

@iwangjie iwangjie Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a switch needs to be added here, otherwise all requests will go through this webfilter

Hi. do you mean a rule-level switch or a gateway-level switch? or plugin-level ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gateway-level , in application.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gateway-level , in application.yaml

OK, see what you mean. I'll fix it.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #4522 (556038d) into master (1239d35) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master    #4522      +/-   ##
============================================
- Coverage     68.55%   68.54%   -0.02%     
- Complexity     7636     7638       +2     
============================================
  Files          1028     1028              
  Lines         29443    29447       +4     
  Branches       2667     2667              
============================================
- Hits          20185    20183       -2     
- Misses         7661     7668       +7     
+ Partials       1597     1596       -1     
Impacted Files Coverage Δ
.../org/apache/shenyu/common/config/ShenyuConfig.java 67.41% <25.00%> (-0.49%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone Apr 6, 2023
@yu199195 yu199195 merged commit b910b85 into apache:master Apr 6, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants