Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fix] fix MemorySafeWindowTinyLFUMap memory leak error #4524

Merged
merged 5 commits into from
Apr 2, 2023

Conversation

xuyicheng1995
Copy link
Contributor

@xuyicheng1995 xuyicheng1995 commented Apr 1, 2023

[ISSUE #4475] fix MemorySafeWindowTinyLFUMap memory leak error fix #4475

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@xuyicheng1995
Copy link
Contributor Author

@moremind please help me review the code

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Merging #4524 (4282651) into master (09b236e) will increase coverage by 0.06%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##             master    #4524      +/-   ##
============================================
+ Coverage     68.37%   68.44%   +0.06%     
- Complexity     7612     7627      +15     
============================================
  Files          1028     1028              
  Lines         29433    29440       +7     
  Branches       2665     2666       +1     
============================================
+ Hits          20125    20150      +25     
+ Misses         7711     7694      -17     
+ Partials       1597     1596       -1     
Impacted Files Coverage Δ
...henyu/common/cache/MemorySafeWindowTinyLFUMap.java 67.16% <62.50%> (-6.17%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@loongs-zhang loongs-zhang added the type: bug Something isn't working label Apr 2, 2023
@loongs-zhang loongs-zhang added this to the 2.6.0 milestone Apr 2, 2023
@loongs-zhang loongs-zhang merged commit 4491cb8 into apache:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <may MemorySafeWindowTinyLFUMap cause a memory leak>
3 participants