Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for ApiDto. #4564

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

crudboy
Copy link
Contributor

@crudboy crudboy commented Apr 17, 2023

add validation for ApiDto.

add validation for ApiDto.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #4564 (5cf9a3f) into master (9fbcf2a) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4564      +/-   ##
============================================
- Coverage     68.94%   68.88%   -0.07%     
+ Complexity     7737     7733       -4     
============================================
  Files          1033     1033              
  Lines         29577    29577              
  Branches       2673     2673              
============================================
- Hits          20392    20374      -18     
- Misses         7586     7604      +18     
  Partials       1599     1599              
Impacted Files Coverage Δ
...java/org/apache/shenyu/admin/model/dto/ApiDTO.java 68.18% <ø> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit 083060c into apache:master Apr 18, 2023
@yu199195
Copy link
Member

@crudboy hi, you can add my wechat, xixy199195

yu199195 added a commit to yu199195/shenyu that referenced this pull request May 5, 2023
add validation for ApiDto.

Co-authored-by: xiaoyu <xiaoyu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants