Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:refactor] refactor shenyu selector and rule cache #4578

Merged
merged 59 commits into from
May 16, 2023

Conversation

moremind
Copy link
Member

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@moremind moremind added this to the 2.6.0 milestone May 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #4578 (df8abd5) into master (05f80fc) will decrease coverage by 0.02%.
The diff coverage is 54.41%.

@@             Coverage Diff              @@
##             master    #4578      +/-   ##
============================================
- Coverage     67.44%   67.42%   -0.02%     
- Complexity     7959     8000      +41     
============================================
  Files          1095     1096       +1     
  Lines         31296    31529     +233     
  Branches       2813     2859      +46     
============================================
+ Hits          21108    21260     +152     
- Misses         8531     8596      +65     
- Partials       1657     1673      +16     
Impacted Files Coverage Δ
...apache/shenyu/admin/controller/RuleController.java 100.00% <ø> (ø)
...he/shenyu/admin/controller/SelectorController.java 100.00% <ø> (ø)
.../admin/model/event/dict/BatchDictDeletedEvent.java 0.00% <ø> (ø)
...odel/event/metadata/BatchMetaDataDeletedEvent.java 0.00% <ø> (ø)
...in/model/event/plugin/BatchPluginDeletedEvent.java 0.00% <ø> (ø)
...odel/event/resource/BatchResourceCreatedEvent.java 69.23% <ø> (ø)
...odel/event/resource/BatchResourceDeletedEvent.java 0.00% <ø> (ø)
.../admin/model/event/role/BatchRoleDeletedEvent.java 0.00% <ø> (ø)
.../admin/model/event/rule/BatchRuleDeletedEvent.java 0.00% <ø> (ø)
...henyu/admin/model/event/rule/RuleUpdatedEvent.java 0.00% <ø> (ø)
... and 34 more

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-keguo li-keguo requested a review from yu199195 May 13, 2023 13:20
@yu199195 yu199195 merged commit cc1afd9 into apache:master May 16, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants