Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hystrix fallback bug #4593

Merged
merged 22 commits into from
May 5, 2023
Merged

fix hystrix fallback bug #4593

merged 22 commits into from
May 5, 2023

Conversation

yu199195
Copy link
Member

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@yu199195 yu199195 added type: bug Something isn't working plugin: hystrix labels Apr 27, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Apr 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #4593 (e40196a) into master (1b961cd) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #4593   +/-   ##
=========================================
  Coverage     67.64%   67.65%           
- Complexity     7872     7875    +3     
=========================================
  Files          1077     1077           
  Lines         30767    30767           
  Branches       2805     2806    +1     
=========================================
+ Hits          20811    20814    +3     
+ Misses         8329     8325    -4     
- Partials       1627     1628    +1     
Impacted Files Coverage Δ
...e/shenyu/plugin/base/fallback/FallbackHandler.java 36.84% <0.00%> (-17.01%) ⬇️
.../apache/shenyu/plugin/hystrix/command/Command.java 7.69% <0.00%> (+2.69%) ⬆️
.../shenyu/plugin/hystrix/command/HystrixCommand.java 55.55% <0.00%> (ø)
...plugin/hystrix/command/HystrixCommandOnThread.java 61.11% <0.00%> (ø)
...shenyu/web/fallback/DefaultFallbackController.java 75.00% <0.00%> (-25.00%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tuohai666
tuohai666 previously approved these changes May 4, 2023
@JooKS-me JooKS-me merged commit 52ebd69 into apache:master May 5, 2023
35 checks passed
@yu199195 yu199195 deleted the fix-hystrix branch June 27, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants