Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix can not load favicon.ico in dashboard #4605

Merged
merged 4 commits into from
May 3, 2023

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented May 3, 2023

fix can not load favicon.ico in dashboard

relate shenyu-dashboard pr apache/shenyu-dashboard#278

before:

2023-05-03 14 52 00

after:

2023-05-03 14 53 10

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@li-keguo
Copy link
Member

li-keguo commented May 3, 2023

Please use the file commit after building the front-end repository

@tomsun28
Copy link
Contributor Author

tomsun28 commented May 3, 2023

Please use the file commit after building the front-end repository

Updated. @li-keguo Please review. thanks!

@li-keguo li-keguo merged commit 48377d8 into apache:master May 3, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants