Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor need rule #4635

Merged
merged 5 commits into from May 15, 2023
Merged

refactor need rule #4635

merged 5 commits into from May 15, 2023

Conversation

yu199195
Copy link
Member

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@yu199195 yu199195 added this to the 2.6.0 milestone May 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4635 (69782c1) into master (bcb8731) will decrease coverage by 0.11%.
The diff coverage is 28.12%.

@@             Coverage Diff              @@
##             master    #4635      +/-   ##
============================================
- Coverage     67.70%   67.60%   -0.11%     
- Complexity     7961     7964       +3     
============================================
  Files          1094     1094              
  Lines         31207    31283      +76     
  Branches       2812     2817       +5     
============================================
+ Hits          21129    21149      +20     
- Misses         8420     8478      +58     
+ Partials       1658     1656       -2     
Impacted Files Coverage Δ
...a/org/apache/shenyu/common/constant/Constants.java 66.66% <ø> (ø)
...nyu/common/dto/convert/rule/RateLimiterHandle.java 59.45% <0.00%> (-13.88%) ⬇️
...ache/shenyu/common/dto/convert/rule/WafHandle.java 47.36% <0.00%> (-12.64%) ⬇️
.../common/dto/convert/rule/impl/CacheRuleHandle.java 83.33% <0.00%> (-16.67%) ⬇️
...to/convert/rule/impl/ContextMappingRuleHandle.java 45.00% <0.00%> (-2.37%) ⬇️
...common/dto/convert/rule/impl/DivideRuleHandle.java 73.52% <0.00%> (-2.23%) ⬇️
.../common/dto/convert/rule/impl/DubboRuleHandle.java 65.62% <0.00%> (-2.12%) ⬇️
...n/dto/convert/rule/impl/SpringCloudRuleHandle.java 58.33% <0.00%> (-11.67%) ⬇️
...mon/dto/convert/rule/impl/WebSocketRuleHandle.java 66.66% <0.00%> (-3.34%) ⬇️
...pache/shenyu/plugin/base/AbstractShenyuPlugin.java 57.83% <0.00%> (-0.36%) ⬇️
... and 41 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moremind moremind merged commit df91d87 into apache:master May 15, 2023
35 checks passed
@yu199195 yu199195 deleted the def-rule branch June 27, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants