Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discobery sync -zk #4636

Merged
merged 25 commits into from May 16, 2023
Merged

Discobery sync -zk #4636

merged 25 commits into from May 16, 2023

Conversation

ywj1352
Copy link
Contributor

@ywj1352 ywj1352 commented May 15, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

zk data tree
/shenyu/proxySelectorData/{pluginName}/{proxySelectorName}
{"id":"1","name":"tcp","pluginName":"TcpProxyPlugin","type":"TCP","forwardPort":9600,"props":{},"discoveryUpstreamList":[{"weight":0,"protocol":"tcp","upstreamUrl":"127.0.0.1:3306","status":true,"timestamp":0}]}
Test:
add zk data
image
gateWay Logs
image
mysql proxy works
image

then delete by zk
image
gateway logs

image mysql proxy client

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #4636 (e044b00) into master (05f80fc) will increase coverage by 0.02%.
The diff coverage is 19.14%.

@@             Coverage Diff              @@
##             master    #4636      +/-   ##
============================================
+ Coverage     67.44%   67.47%   +0.02%     
- Complexity     7959     7962       +3     
============================================
  Files          1095     1096       +1     
  Lines         31296    31341      +45     
  Branches       2813     2820       +7     
============================================
+ Hits          21108    21147      +39     
- Misses         8531     8535       +4     
- Partials       1657     1659       +2     
Impacted Files Coverage Δ
...e/shenyu/common/constant/DefaultPathConstants.java 88.88% <ø> (ø)
...rg/apache/shenyu/common/dto/ProxySelectorData.java 0.00% <0.00%> (ø)
.../base/cache/CommonProxySelectorDataSubscriber.java 0.00% <0.00%> (ø)
.../sync/data/zookeeper/ZookeeperSyncDataService.java 57.14% <17.24%> (-9.03%) ⬇️
...arter/plugin/global/GlobalPluginConfiguration.java 100.00% <100.00%> (ø)
...data/zookeeper/ZookeeperSyncDataConfiguration.java 42.85% <100.00%> (+4.39%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone May 16, 2023
@yu199195 yu199195 merged commit fad18eb into apache:master May 16, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants