Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for ShenyuSdkClientFactory class. #4645

Merged
merged 5 commits into from
May 29, 2023
Merged

add test case for ShenyuSdkClientFactory class. #4645

merged 5 commits into from
May 29, 2023

Conversation

omernaci
Copy link
Contributor

@omernaci omernaci commented May 19, 2023

Related to #4537

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2023

Codecov Report

Merging #4645 (5636a7d) into master (347b406) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4645      +/-   ##
============================================
- Coverage     66.91%   66.45%   -0.47%     
- Complexity     8004     8005       +1     
============================================
  Files          1099     1109      +10     
  Lines         31758    31992     +234     
  Branches       2874     2888      +14     
============================================
+ Hits          21252    21259       +7     
- Misses         8829     9056     +227     
  Partials       1677     1677              

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moremind
Copy link
Member

Hi, @omernaci pls check ci work flow

@omernaci
Copy link
Contributor Author

Hi @moremind, I trigger again, the build is successful now. Can you approve this PR?

@moremind moremind merged commit 21366c4 into apache:master May 29, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants