Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:refactor] refactor cache and add endpoint to expose cache #4658

Merged
merged 19 commits into from
May 27, 2023

Conversation

moremind
Copy link
Member

@moremind moremind commented May 22, 2023

Fixes #4641

  1. clean match cache
  2. expose endpoint

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #4658 (5ac502f) into master (347b406) will decrease coverage by 0.15%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #4658      +/-   ##
============================================
- Coverage     66.91%   66.77%   -0.15%     
+ Complexity     8005     8001       -4     
============================================
  Files          1099     1099              
  Lines         31758    31789      +31     
  Branches       2874     2878       +4     
============================================
- Hits          21252    21228      -24     
- Misses         8829     8867      +38     
- Partials       1677     1694      +17     
Impacted Files Coverage Δ
...pache/shenyu/plugin/base/AbstractShenyuPlugin.java 57.81% <0.00%> (+4.16%) ⬆️
...apache/shenyu/plugin/base/cache/MetaDataCache.java 0.00% <0.00%> (ø)
...org/apache/shenyu/plugin/base/trie/ShenyuTrie.java 75.43% <0.00%> (-0.66%) ⬇️
.../shenyu/web/endpoint/ShenyuControllerEndpoint.java 0.00% <0.00%> (ø)
...pache/shenyu/plugin/base/cache/MatchDataCache.java 71.79% <35.29%> (-28.21%) ⬇️
.../plugin/base/cache/CommonPluginDataSubscriber.java 62.50% <40.90%> (-3.41%) ⬇️
...pringboot/starter/gateway/ShenyuConfiguration.java 88.88% <100.00%> (ø)
...e/shenyu/web/controller/LocalPluginController.java 87.61% <100.00%> (ø)

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yu199195
yu199195 previously approved these changes May 24, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone May 27, 2023
@yu199195 yu199195 merged commit 0c28097 into apache:master May 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] expose shenyu cache by endpoint
4 participants