Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code of sentinel-plugin #4669

Merged
merged 4 commits into from May 26, 2023

Conversation

6freeair2016
Copy link
Contributor

@6freeair2016 6freeair2016 commented May 26, 2023

Optimize code of sentinel-plugin【issueNo: 4668】

Make sure that:

  • [✔] You have read the contribution guidelines.
  • [✔ ] You submit test cases (unit or integration tests) that back your changes.
  • [✔ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

# Conflicts:
#	shenyu-plugin/shenyu-plugin-sentinel/src/main/java/org/apache/shenyu/plugin/sentinel/SentinelPlugin.java
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #4669 (c2f9fdf) into master (f3aa857) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #4669      +/-   ##
============================================
- Coverage     66.93%   66.92%   -0.01%     
+ Complexity     8006     8005       -1     
============================================
  Files          1099     1099              
  Lines         31758    31758              
  Branches       2874     2874              
============================================
- Hits          21257    21255       -2     
- Misses         8824     8827       +3     
+ Partials       1677     1676       -1     
Impacted Files Coverage Δ
...a/org/apache/shenyu/common/constant/Constants.java 83.33% <ø> (ø)
...shenyu/common/dto/convert/rule/SentinelHandle.java 80.26% <50.00%> (ø)
.../apache/shenyu/plugin/sentinel/SentinelPlugin.java 63.15% <100.00%> (ø)
...yu/plugin/sentinel/handler/SentinelRuleHandle.java 80.39% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@loongs-zhang loongs-zhang merged commit 347b406 into apache:master May 26, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants