Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fix] fix springmvc and springcloud client #4681

Merged
merged 2 commits into from
May 30, 2023

Conversation

moremind
Copy link
Member

@moremind moremind commented May 29, 2023

Fixes #4514 #4674 #4512

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Merging #4681 (d30d9a9) into master (9455e45) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4681      +/-   ##
============================================
- Coverage     66.91%   66.91%   -0.01%     
+ Complexity     8015     8011       -4     
============================================
  Files          1099     1099              
  Lines         31801    31807       +6     
  Branches       2882     2882              
============================================
+ Hits          21279    21283       +4     
- Misses         8830     8833       +3     
+ Partials       1692     1691       -1     
Impacted Files Coverage Δ
...ringcloud/init/SpringCloudClientEventListener.java 72.72% <100.00%> (+0.76%) ⬆️
...t/springmvc/init/SpringMvcClientEventListener.java 76.85% <100.00%> (+0.66%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit 49a3b60 into apache:master May 30, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] <isFull set true, "code": -119>
3 participants