Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4548] Add unit test to the sofa component. #4688

Merged
merged 1 commit into from
May 31, 2023

Conversation

December-Pb
Copy link
Contributor

In this PR, the unit tests of buildApiPath, buildMetaDataDTO in the class SofaServiceEventListener were added

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #4688 (9215c61) into master (23af5ff) will increase coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4688      +/-   ##
============================================
+ Coverage     66.43%   66.62%   +0.19%     
- Complexity     8015     8032      +17     
============================================
  Files          1109     1109              
  Lines         32041    32041              
  Branches       2896     2896              
============================================
+ Hits          21285    21346      +61     
+ Misses         9065     9003      -62     
- Partials       1691     1692       +1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone May 31, 2023
@yu199195 yu199195 merged commit 2832b8f into apache:master May 31, 2023
35 checks passed
@December-Pb December-Pb deleted the SofaServiceEventListenerTest branch May 31, 2023 17:47
@tian-pengfei
Copy link
Contributor

@December-Pb
I think the SofaServiceEventListenerTest.testBuildMetaDataDTO method has a problem.

Sometimes the expected one's timeMillis is diffrent from the actual's ,Because of the difference of creation time

image

5cf5a5971672a56fcf3cd68a29f71c2

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants