Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance #4696]Enhance global exception handling:Some abnormal errors were not captured and handled. eg:xxxx.com/cloudPolicy/n/te";'st/unsignedd #4709

Merged
merged 61 commits into from
Jun 8, 2023

Conversation

lianjunwei
Copy link
Contributor

#4696
http://xxxx.com/cloudPolicy/n/te"'st/unsignedd
The security engineer used the above url to conduct penetration test and found that,some abnormal errors were not captured and handled, resulting in system information leakage.

fix:Capture errors and do not output sensitive information such as system information and internal stacks.

lianjunwei and others added 30 commits June 9, 2022 01:26
yes
 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
# Conflicts:
#	shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
ok# 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
lianjunwei and others added 23 commits May 31, 2023 19:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #4709 (a4348ba) into master (23aa4f6) will increase coverage by 0.22%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master    #4709      +/-   ##
============================================
+ Coverage     66.27%   66.49%   +0.22%     
- Complexity     8009     8040      +31     
============================================
  Files          1111     1111              
  Lines         32166    32169       +3     
  Branches       2906     2907       +1     
============================================
+ Hits          21317    21391      +74     
+ Misses         9155     9082      -73     
- Partials       1694     1696       +2     
Impacted Files Coverage Δ
.../apache/shenyu/web/handler/GlobalErrorHandler.java 76.47% <60.00%> (-9.25%) ⬇️

... and 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants