-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance #4696]Enhance global exception handling:Some abnormal errors were not captured and handled. eg:xxxx.com/cloudPolicy/n/te";'st/unsignedd #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 3603 ooo �
yes 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
# Conflicts: # shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
ok# 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
…l errors were not captured and handled. eg:http://xxxx.com/cloudPolicy/n/te"'st/unsignedd
…errors were not captured and handled. eg:http://xxxx.com/cloudPolicy/n/te"'st/unsignedd
…l errors were not captured and handled. eg:http://xxxx.com/cloudPolicy/n/te"'st/unsignedd
…errors were not captured and handled. eg:http://xxxx.com/cloudPolicy/n/te"'st/unsignedd
Codecov Report
@@ Coverage Diff @@
## master #4709 +/- ##
============================================
+ Coverage 66.27% 66.49% +0.22%
- Complexity 8009 8040 +31
============================================
Files 1111 1111
Lines 32166 32169 +3
Branches 2906 2907 +1
============================================
+ Hits 21317 21391 +74
+ Misses 9155 9082 -73
- Partials 1694 1696 +2
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
approved these changes
Jun 8, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4696
http://xxxx.com/cloudPolicy/n/te"'st/unsignedd
The security engineer used the above url to conduct penetration test and found that,some abnormal errors were not captured and handled, resulting in system information leakage.
fix:Capture errors and do not output sensitive information such as system information and internal stacks.