Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change discovery_upstream discovery_handler_id #4710

Merged
merged 11 commits into from
Jun 9, 2023

Conversation

ywj1352
Copy link
Contributor

@ywj1352 ywj1352 commented Jun 8, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #4710 (81d37e0) into master (f76a287) will decrease coverage by 0.01%.
The diff coverage is 38.88%.

@@             Coverage Diff              @@
##             master    #4710      +/-   ##
============================================
- Coverage     66.26%   66.26%   -0.01%     
- Complexity     8009     8014       +5     
============================================
  Files          1111     1111              
  Lines         32182    32182              
  Branches       2907     2907              
============================================
- Hits          21326    21325       -1     
  Misses         9159     9159              
- Partials       1697     1698       +1     
Impacted Files Coverage Δ
...tener/http/HttpLongPollingDataChangedListener.java 5.88% <0.00%> (ø)
...e/shenyu/admin/service/impl/DetailServiceImpl.java 77.55% <0.00%> (ø)
...he/shenyu/admin/service/impl/FieldServiceImpl.java 88.46% <0.00%> (ø)
.../java/org/apache/shenyu/admin/utils/HttpUtils.java 36.72% <0.00%> (ø)
...client/brpc/BrpcContextRefreshedEventListener.java 69.44% <0.00%> (ø)
...enyu/client/tars/TarsServiceBeanEventListener.java 80.68% <0.00%> (ø)
.../java/org/apache/shenyu/common/utils/MapUtils.java 37.50% <0.00%> (ø)
...henyu/plugin/brpc/spi/SharedThreadPoolFactory.java 0.00% <0.00%> (ø)
...henyu/plugin/httpclient/NettyHttpClientPlugin.java 35.71% <0.00%> (ø)
...java/org/apache/shenyu/plugin/sofa/SofaPlugin.java 82.75% <0.00%> (ø)
... and 10 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mahaitao617
mahaitao617 previously approved these changes Jun 8, 2023
yu199195
yu199195 previously approved these changes Jun 8, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Jun 8, 2023
@ywj1352 ywj1352 dismissed stale reviews from mahaitao617 and yu199195 via 11e87be June 9, 2023 06:43
@mahaitao617 mahaitao617 merged commit beefc13 into apache:master Jun 9, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants