Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/check-passsword-support-I18n #4758

Merged
merged 9 commits into from
Jun 25, 2023

Conversation

li-keguo
Copy link
Member

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #4758 (e632f32) into master (6ed35b2) will decrease coverage by 0.08%.
The diff coverage is 14.89%.

@@             Coverage Diff              @@
##             master    #4758      +/-   ##
============================================
- Coverage     66.42%   66.34%   -0.08%     
- Complexity     8107     8112       +5     
============================================
  Files          1118     1121       +3     
  Lines         32523    32566      +43     
  Branches       2936     2937       +1     
============================================
+ Hits          21603    21606       +3     
- Misses         9207     9244      +37     
- Partials       1713     1716       +3     
Impacted Files Coverage Δ
...g/apache/shenyu/admin/exception/I18nException.java 0.00% <0.00%> (ø)
...pache/shenyu/admin/exception/WebI18nException.java 0.00% <0.00%> (ø)
...pache/shenyu/admin/model/dto/DashboardUserDTO.java 75.92% <ø> (ø)
...dmin/model/dto/DashboardUserModifyPasswordDTO.java 72.00% <ø> (ø)
...u/admin/service/impl/DashboardUserServiceImpl.java 70.86% <0.00%> (ø)
...a/org/apache/shenyu/admin/utils/WebI18nAssert.java 0.00% <0.00%> (ø)
.../admin/aspect/controller/RestControllerAspect.java 90.00% <33.33%> (-10.00%) ⬇️
...ache/shenyu/admin/exception/ExceptionHandlers.java 90.47% <60.00%> (-4.27%) ⬇️
.../shenyu/admin/config/ShenyuAdminConfiguration.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit 5531229 into apache:master Jun 25, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants