-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SplitDiscovery & websocketDataSync & integration CURD #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4768 +/- ##
============================================
+ Coverage 65.75% 65.78% +0.02%
- Complexity 8139 8173 +34
============================================
Files 1131 1133 +2
Lines 32975 33139 +164
Branches 2956 2966 +10
============================================
+ Hits 21683 21800 +117
- Misses 9563 9611 +48
+ Partials 1729 1728 -1
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true
.use websocket to sync data && use zookeeper to discovery mode
![image](https://private-user-images.githubusercontent.com/31105009/248832756-2acd9214-7386-4d73-b81b-945264f268e3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzQxMDcsIm5iZiI6MTcyNDE3MzgwNywicGF0aCI6Ii8zMTEwNTAwOS8yNDg4MzI3NTYtMmFjZDkyMTQtNzM4Ni00ZDczLWI4MWItOTQ1MjY0ZjI2OGUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDE3MTAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM3Mjc1Yjc3MGFiZDYwNTUxZDdmNDYzYjUxOGZlN2Q0ODYxMzNmMDU5Yjk0YWU5MjMxMDRkYmJlYjEzZjAzYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.i9MpLenXjS3SVOf2O4rmB4KOfN36d5aaTiBBuDwskHw)
![image](https://private-user-images.githubusercontent.com/31105009/248833213-ba3e0c9b-43ea-428d-b301-935eeb777e5d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzQxMDcsIm5iZiI6MTcyNDE3MzgwNywicGF0aCI6Ii8zMTEwNTAwOS8yNDg4MzMyMTMtYmEzZTBjOWItNDNlYS00MjhkLWIzMDEtOTM1ZWViNzc3ZTVkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDE3MTAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUyMWVlNjE0ODdkMjE1ZmUxYjNhZTNiYmE4OTg1NDIzYWEyOGZkOWI4NzM2MGI5MzgxNTQ4NmNhZGY5OGMyZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qBlE9QRdNx0HLSUv7pV4DAMtVSoeLZgkw1iNDo3OfwY)
![image](https://private-user-images.githubusercontent.com/31105009/248833547-fd221d5f-208a-49c8-8f0b-2ca9ebd5157a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzQxMDcsIm5iZiI6MTcyNDE3MzgwNywicGF0aCI6Ii8zMTEwNTAwOS8yNDg4MzM1NDctZmQyMjFkNWYtMjA4YS00OWM4LThmMGItMmNhOWViZDUxNTdhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDE3MTAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM4MjljMDc4NzA2ZDc0MDE4NTg1YjE3OGEwZDhkYmRiMDI5ZTRmMDRmNjM3MjI5YjlhMTMxZWVkNDg1NThlZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.LlDVR_ydfaLMgqZKU7UIxWznFatywOc73zPqHSBTDKw)
![image](https://private-user-images.githubusercontent.com/31105009/248833814-29546dad-7fd7-41ca-8484-256001433c3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzQxMDcsIm5iZiI6MTcyNDE3MzgwNywicGF0aCI6Ii8zMTEwNTAwOS8yNDg4MzM4MTQtMjk1NDZkYWQtN2ZkNy00MWNhLTg0ODQtMjU2MDAxNDMzYzNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDE3MTAwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyMjJjZjM1OWE4NWRjZWY3YjdiZDFhMjFhMDViZmM1NDkyOWY2MGVjZmJlZjQwYmE2Mjk5NDE2YTY4ZDg4MDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.K3za4oXE8qjRNMKIwzdKn8w61UIuKw1HeoMBm-kVgrY)
fail to create connection to 9878 port
then i
create -e /shenyu/discovery/tcp/1/1/1 {"id":"123456","discoveryHandlerId":"1","protocol":"http","url":"127.0.0.1:6379","status":1,"weight":10,"props":"{}"}
ShenyuGateway find log
then success create connection to 9878 port