Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitDiscovery & websocketDataSync & integration CURD #4768

Merged
merged 18 commits into from
Jun 29, 2023

Conversation

ywj1352
Copy link
Contributor

@ywj1352 ywj1352 commented Jun 26, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

use websocket to sync data && use zookeeper to discovery mode
image
fail to create connection to 9878 port
image
then i create -e /shenyu/discovery/tcp/1/1/1 {"id":"123456","discoveryHandlerId":"1","protocol":"http","url":"127.0.0.1:6379","status":1,"weight":10,"props":"{}"}
ShenyuGateway find log
image
then success create connection to 9878 port
image

@ywj1352 ywj1352 closed this Jun 26, 2023
@ywj1352 ywj1352 reopened this Jun 28, 2023
@ywj1352 ywj1352 changed the title Split discovery and add websocket to data sync SplitDiscovery & websocketDataSync & integration CURD Jun 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #4768 (6b7a022) into master (07127d3) will increase coverage by 0.02%.
The diff coverage is 23.98%.

@@             Coverage Diff              @@
##             master    #4768      +/-   ##
============================================
+ Coverage     65.75%   65.78%   +0.02%     
- Complexity     8139     8173      +34     
============================================
  Files          1131     1133       +2     
  Lines         32975    33139     +164     
  Branches       2956     2966      +10     
============================================
+ Hits          21683    21800     +117     
- Misses         9563     9611      +48     
+ Partials       1729     1728       -1     
Impacted Files Coverage Δ
...scovery/DiscoveryDataChangedEventSyncListener.java 0.00% <0.00%> (ø)
...enyu/admin/discovery/DiscoveryProcessorHolder.java 44.44% <0.00%> (-12.70%) ⬇️
...henyu/admin/discovery/LocalDiscoveryProcessor.java 16.00% <0.00%> (+16.00%) ⬆️
...discovery/parse/CustomDiscoveryUpstreamParser.java 0.00% <0.00%> (ø)
...dmin/listener/AbstractListDataChangedListener.java 77.91% <0.00%> (-0.33%) ⬇️
...dmin/listener/AbstractNodeDataChangedListener.java 72.52% <0.00%> (-8.96%) ⬇️
...nyu/admin/listener/DataChangedEventDispatcher.java 76.92% <0.00%> (-6.42%) ⬇️
...che/shenyu/admin/listener/DataChangedListener.java 0.00% <0.00%> (ø)
...stener/websocket/WebsocketDataChangedListener.java 72.41% <0.00%> (-27.59%) ⬇️
...he/shenyu/admin/model/dto/ProxySelectorAddDTO.java 20.00% <0.00%> (-1.06%) ⬇️
... and 22 more

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit 86d65f2 into apache:master Jun 29, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants