Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] HttpLongPolling Sync DiscoveryData #4795

Merged
merged 21 commits into from
Jul 4, 2023

Conversation

ywj1352
Copy link
Contributor

@ywj1352 ywj1352 commented Jul 4, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #4795 (6cc8807) into master (a5a0779) will increase coverage by 0.05%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #4795      +/-   ##
============================================
+ Coverage     65.21%   65.26%   +0.05%     
- Complexity     8138     8151      +13     
============================================
  Files          1136     1138       +2     
  Lines         33374    33425      +51     
  Branches       2975     2975              
============================================
+ Hits          21765    21815      +50     
- Misses         9878     9883       +5     
+ Partials       1731     1727       -4     
Impacted Files Coverage Δ
...yu/admin/listener/AbstractDataChangedListener.java 81.39% <0.00%> (-13.20%) ⬇️
...tener/http/HttpLongPollingDataChangedListener.java 5.69% <0.00%> (-0.20%) ⬇️
...he/shenyu/admin/model/dto/ProxySelectorAddDTO.java 19.04% <0.00%> (-0.96%) ⬇️
...u/admin/service/impl/ProxySelectorServiceImpl.java 20.23% <0.00%> (ø)
...ata/http/refresh/DiscoveryUpstreamDataRefresh.java 42.85% <42.85%> (ø)
...u/sync/data/http/refresh/ProxySelectorRefresh.java 42.85% <42.85%> (ø)
...rter/sync/data/http/HttpSyncDataConfiguration.java 84.21% <100.00%> (+1.85%) ⬆️
...che/shenyu/sync/data/http/HttpSyncDataService.java 90.81% <100.00%> (+29.59%) ⬆️
...nyu/sync/data/http/refresh/DataRefreshFactory.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone Jul 4, 2023
@yu199195 yu199195 merged commit ff17ae6 into apache:master Jul 4, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants