Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4842] fix shenyu admin cannot configure consule port #4843

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

xuziyang
Copy link
Contributor

fix shenyu admin cannot configure consule port when using consul as register

@codecov-commenter
Copy link

Codecov Report

Merging #4843 (b2d3382) into master (bf61e5e) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #4843      +/-   ##
============================================
+ Coverage     64.60%   64.62%   +0.02%     
- Complexity     8205     8208       +3     
============================================
  Files          1153     1153              
  Lines         33999    34013      +14     
  Branches       3041     3045       +4     
============================================
+ Hits          21965    21982      +17     
+ Misses        10303    10292      -11     
- Partials       1731     1739       +8     
Impacted Files Coverage Δ
...shenyu/admin/config/ConsulServerConfiguration.java 55.55% <42.85%> (-44.45%) ⬇️
...r/consul/ConsulClientServerRegisterRepository.java 87.71% <55.55%> (-6.16%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone Jul 14, 2023
@yu199195 yu199195 merged commit 4ea79fa into apache:master Jul 14, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants