Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4853] Fixed could not update uri in Match mode #4854

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

tian-pengfei
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Fixed #4853

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #4854 (a4edef6) into master (701a11d) will increase coverage by 0.11%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #4854      +/-   ##
============================================
+ Coverage     64.43%   64.54%   +0.11%     
- Complexity     8203     8213      +10     
============================================
  Files          1160     1160              
  Lines         34085    34086       +1     
  Branches       3055     3055              
============================================
+ Hits          21962    22001      +39     
+ Misses        10380    10345      -35     
+ Partials       1743     1740       -3     
Impacted Files Coverage Δ
...a/org/apache/shenyu/admin/service/RuleService.java 80.00% <50.00%> (+2.22%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tian-pengfei tian-pengfei changed the title [ISSUE #4853] Fixed could not update uri in PathPattern mode [ISSUE #4853] Fixed could not update uri in Match mode Jul 16, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Jul 17, 2023
@yu199195 yu199195 merged commit 206c1b0 into apache:master Jul 17, 2023
37 checks passed
@tian-pengfei tian-pengfei deleted the #4853 branch July 19, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Could not update uri in Match mode
3 participants