Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when shenyu register by consul, the prop 'metadata-path' config is invalid and error occurred in MetaDataRegister when the path had special symbol '{}',such as '/path/{id}/{name}' #4885

Merged
merged 9 commits into from
Jul 25, 2023

Conversation

yu1183688986
Copy link
Contributor

@yu1183688986 yu1183688986 commented Jul 20, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

…s invalid and error occurred in MetaDataRegister when the path had special symbol '{}',such as '/path/{id}/{name}'.

Signed-off-by: 清溪先生 <usfree2021@163.com>
Signed-off-by: 清溪先生 <usfree2021@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #4885 (7153675) into master (7822ec0) will decrease coverage by 0.12%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #4885      +/-   ##
============================================
- Coverage     64.02%   63.90%   -0.12%     
- Complexity     8236     8240       +4     
============================================
  Files          1168     1169       +1     
  Lines         34459    34541      +82     
  Branches       3091     3107      +16     
============================================
+ Hits          22062    22075      +13     
- Misses        10636    10702      +66     
- Partials       1761     1764       +3     
Files Changed Coverage Δ
.../client/consul/ConsulClientRegisterRepository.java 26.82% <50.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit 3d3cafe into apache:master Jul 25, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants